New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing SIGSEGV when running containers #303

Merged
merged 1 commit into from Jul 6, 2017

Conversation

Projects
None yet
5 participants
@yastij
Contributor

yastij commented Jul 6, 2017

Signed-off-by: Yassine TIJANI yasstij11@gmail.com

- How I did it checking that close is not before deferring it.

fixes moby/moby#33975

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 6, 2017

Codecov Report

Merging #303 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   48.68%   48.68%           
=======================================
  Files         185      185           
  Lines       12168    12168           
=======================================
  Hits         5924     5924           
  Misses       5877     5877           
  Partials      367      367

codecov-io commented Jul 6, 2017

Codecov Report

Merging #303 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   48.68%   48.68%           
=======================================
  Files         185      185           
  Lines       12168    12168           
=======================================
  Hits         5924     5924           
  Misses       5877     5877           
  Partials      367      367
@dnephin

Thanks for the fix!

Show outdated Hide outdated cli/command/container/run.go
@yastij

This comment has been minimized.

Show comment
Hide comment
@yastij

yastij Jul 6, 2017

Contributor

@dnephin - LGTY ?

Contributor

yastij commented Jul 6, 2017

@dnephin - LGTY ?

@dnephin

LGTM, thanks!

Please also squash to a single git commit.

fixing SIGSEGV when running containers
Signed-off-by: Yassine TIJANI <yasstij11@gmail.com>

moving the deffering of the close after the error checking

Signed-off-by: Yassine TIJANI <yasstij11@gmail.com>

fixing SIGSEGV when running containers

Signed-off-by: Yassine TIJANI <yasstij11@gmail.com>
@yastij

This comment has been minimized.

Show comment
Hide comment
@yastij

yastij Jul 6, 2017

Contributor

@dnephin - Done.

Contributor

yastij commented Jul 6, 2017

@dnephin - Done.

@dnephin

dnephin approved these changes Jul 6, 2017

@aaronlehmann

This comment has been minimized.

Show comment
Hide comment
@aaronlehmann

aaronlehmann Jul 6, 2017

Collaborator

LGTM

Collaborator

aaronlehmann commented Jul 6, 2017

LGTM

@aaronlehmann aaronlehmann merged commit dfdbdab into docker:master Jul 6, 2017

6 of 7 checks passed

codecov/patch 0% of diff hit (target 50%)
Details
ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/project 48.68% remains the same compared to 1aa82bc
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.07.0 milestone Jul 6, 2017

@yastij yastij deleted the yastij:fix-SIGSEGV-runContainer branch Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment