Fix checkout behavior and FileVersion

[crazy-max]

Looks like

cli/scripts/build/.variables

Line 7 in 6d2820b

VERSION=${VERSION:-$(git describe --match 'v[0-9]*' --dirty='.m' --always --tags | sed 's/^v//' 2>/dev/null || echo "unknown-version" )}

returns 0530566 which is the commit and not the actual tag.

Seems related to GitHub Actions checkout behavior. We need to fetch all tags otherwise it fails:

cc @thaJeztah

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

[codecov-commenter]

Codecov Report

Merging #3337 (41446ab) into master (6d2820b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3337   +/-   ##
=======================================
  Coverage   57.99%   57.99%           
=======================================
  Files         302      302           
  Lines       21764    21764           
=======================================
  Hits        12621    12621           
  Misses       8219     8219           
  Partials      924      924           

[thaJeztah]

Actually wondering now; shouldn't it show the commit? Because the commit it was built from is not an exact match for a tag (see the ProductVersion)

[crazy-max]

You mean for FileVersion?

Edit: Yes should be like ProductVersion.

[crazy-max]

@thaJeztah Fixed

[thaJeztah]

Given that this previously used VERSION_QUAD, is this field expected to be SemVer(ish)? If so, this will break if our CalVer version has a leading 0 (19.03.9, e.g.)

[thaJeztah]

from https://docs.microsoft.com/en-us/windows/win32/menurc/versioninfo-resource

FILEVERSION

Binary version number for the file. The version consists of two 32-bit integers, defined by four 16-bit integers. For example, "FILEVERSION 3,10,0,61" is translated into two doublewords: 0x0003000a and 0x0000003d, in that order. Therefore, if version is defined by the DWORD values dw1 and dw2, they need to appear in the FILEVERSION statement as follows: HIWORD(dw1), LOWORD(dw1), HIWORD(dw2), LOWORD(dw2).

PRODUCTVERSION

Binary version number for the product with which the file is distributed. The version parameter is two 32-bit integers, defined by four 16-bit integers. For more information about version, see the FILEVERSION description.

[thaJeztah]

Further down, the description is different (sigh)

FileVersion
Version number of the file for example, "3.10" or "5.00.RC2". This string is required.

ProductVersion
Version of the product with which the file is distributed?for example, "3.10" or "5.00.RC2". This string is required

[crazy-max]

Further down, the description is different (sigh)

Yeah can be misleading, VERSIONINFO.FILEVERSION != StringFileInfo.FileVersion. In our case:

VERSIONINFO.FILEVERSION = goversioninfo FixedFileInfo.FileVersion

"FixedFileInfo":
  {
    "FileVersion": {
      "Major": $(echo "$VERSION_QUAD" | cut -d. -f1),
      "Minor": $(echo "$VERSION_QUAD" | cut -d. -f2),
      "Patch": $(echo "$VERSION_QUAD" | cut -d. -f3),
      "Build": $(echo "$VERSION_QUAD" | cut -d. -f4)
    },
  }

StringFileInfo.FileVersion = goversioninfo StringFileInfo.FileVersion

"StringFileInfo":
  {
    "FileVersion": "${VERSION}",
  }

[thaJeztah]

Argh.. yes, that's confusing, thanks!

[thaJeztah]

LGTM