fix missing closing parenthese

[jlecordier]

Added missing closing parenthese

[codecov-commenter]

Codecov Report

Merging #3360 (a185143) into master (3fb4fb8) will decrease coverage by 1.70%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3360      +/-   ##
==========================================
- Coverage   58.02%   56.31%   -1.71%     
==========================================
  Files         302      304       +2     
  Lines       21761    26876    +5115     
==========================================
+ Hits        12626    15135    +2509     
- Misses       8214    10821    +2607     
+ Partials      921      920       -1     

[thaJeztah]

Thank you for contributing! It appears your commit message is missing a DCO sign-off,
causing the DCO check to fail.

We require all commit messages to have a Signed-off-by line with your name
and e-mail (see "Sign your work"
in the CONTRIBUTING.md in this repository), which looks something like:

Signed-off-by: YourFirsName YourLastName <yourname@example.org>

There is no need to open a new pull request, but to fix this (and make CI pass),
you need to amend the commit(s) in this pull request, and "force push" the amended
commit.

Unfortunately, it's not possible to do so through GitHub's web UI, so this needs
to be done through the git commandline.

You can find some instructions in the output of the DCO check (which can be found
in the "checks" tab on this pull request), as well as in the Moby contributing guide.

Steps to do so "roughly" come down to:

1. Set your name and e-mail in git's configuration:

   git config --global user.name "YourFirstName YourLastName"
   git config --global user.email "yourname@example.org"

   (Make sure to use your real name (not your GitHub username/handle) and e-mail)

2. Clone your fork locally

3. Check out the branch associated with this pull request

4. Sign-off and amend the existing commit(s)

   git commit --amend --no-edit --signoff

   If your pull request contains multiple commits, either squash the commits (if
   needed) or sign-off each individual commit.

5. Force push your branch to GitHub (using the --force or --force-with-lease flags) to update the pull request.

Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions!

[thaJeztah]

LGTM, thanks!

[jlecordier]

Hi @thaJeztah, thank you for your time and these explanations. Sorry for the mess, I am not used to all those git commands, and I totally messed my branch up lmao. It should be all clear now

[thaJeztah]

No worries, thanks for updating! I did a quick rebase of the PR to get rid of the extra "merge" commits.

As to the missing DCO line; it happens a lot (I took some time today to write my comment above, and saved it as a "canned reply" so that I can reuse it).

Unfortunately GitHub does not (yet) have an option to either (automatically) add the sign-off when opening a PR from the web UI, or to have a "check" before the PR is opened.

For trivial changes like this, I would've been happy to "ignore' the missing sign-off, but our legal team may disagree (and the DCO bot as well) 😅