New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stats.md add example json output #3378
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3378 +/- ##
==========================================
+ Coverage 56.35% 58.02% +1.66%
==========================================
Files 304 302 -2
Lines 26830 21761 -5069
==========================================
- Hits 15121 12626 -2495
+ Misses 10789 8214 -2575
- Partials 920 921 +1 |
Thank you for contributing! It appears your commit message is missing a DCO sign-off, We require all commit messages to have a
There is no need to open a new pull request, but to fix this (and make CI pass), Unfortunately, it's not possible to do so through GitHub's web UI, so this needs You can find some instructions in the output of the DCO check (which can be found Steps to do so "roughly" come down to:
Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions! |
@thaJeztah hi, added the required sign-off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the sign-off! (sorry for the hassle 😓)
I spotted one minor issue; let me do a quick fix up
docs/reference/commandline/stats.md
Outdated
@@ -85,6 +85,13 @@ b95a83497c91 awesome_brattain 0.28% 5.629MiB / 1.952GiB | |||
67b2525d8ad1 foobar 0.00% 1.727MiB / 1.952GiB 0.09% 2.48kB / 0B 4.11MB / 0B 2 | |||
``` | |||
|
|||
Running `docker stats` on container with name nginx and getting output in ``json`` format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there's double back-ticks around json
. GitHub seems to be fine with that, but let me quickly fix that up and push to this branch (in case docs.docker.com
doesn't like it when generating the HTML) 😅
Signed-off-by: Pieter E Smit <diepes@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add an example producing json output.
- What I did
Add another docker stats format example
- How I did it
Edit in github
- How to verify it
ran on server
- Description for the changelog
Add docker stats example with json output
- A picture of a cute animal (not mandatory but encouraged)