update gotestsum to v1.8.2 #3869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3869 +/- ##
=======================================
Coverage 59.22% 59.22%
=======================================
Files 288 288
Lines 24661 24661
=======================================
Hits 14606 14606
Misses 9171 9171
Partials 884 884 |
|
Oh, fun; probably because newer go version now expect |
|
Was about to add |
|
🤦 looking at the wrong Dockerfile; need to look at Dockerfile.dev |
release notes: https://github.com/gotestyourself/gotestsum/releases/tag/v1.8.2 - Show shuffle seed - Update tests, and cleanup formats - Update dependencies - Test against go1.19, remove go1.15 - Add project name to junit.xml output - Adding in support for s390x and ppc64le full diff: gotestyourself/gotestsum@v1.8.1...v1.8.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Nov 17, 2022
dockerfiles/Dockerfile.dev
Outdated
| @@ -17,7 +17,7 @@ RUN --mount=type=cache,target=/root/.cache/go-build \ | |||
| && gofumpt --version | |||
|
|
|||
| FROM golang AS gotestsum | |||
| ARG GOTESTSUM_VERSION=v0.4.0 | |||
| ARG GOTESTSUM_VERSION=v0.8.2 | |||
There was a problem hiding this comment.
😂
Suggested change
| ARG GOTESTSUM_VERSION=v0.8.2 | |
| ARG GOTESTSUM_VERSION=v1.8.2 |
thaJeztah
force-pushed
the
update_gotestsum
branch
from
dc3ab4d
to
7000991
Compare
vvoland
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release notes: https://github.com/gotestyourself/gotestsum/releases/tag/v1.8.2
full diff: gotestyourself/gotestsum@v1.8.1...v1.8.2
- A picture of a cute animal (not mandatory but encouraged)