docs: fix static ip example, network needs a subnet #4374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4374 +/- ##
=======================================
Coverage 59.29% 59.29%
=======================================
Files 288 288
Lines 24769 24769
=======================================
Hits 14687 14687
Misses 9198 9198
Partials 884 884 |
|
@dvdksn can you do a cherry-pick as well for 24.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--ipERROR: user specified IP address is supported only when connecting to networks with user configured subnets. moby/moby#45806Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com
- What I did
Clarify that static container IPs require networks with an explicit subnet block
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)