[24.0 backport] docker info: fix condition for printing debug information #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The daemon collects this information regardless if "debug" is enabled. Print the debugging information if either the daemon, or the client has debug enabled. We should probably improve this logic and print any of these if set (but some special rules are needed for file-descriptors, which may use "-1". Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 92d7a23) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
neersighted
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The daemon collects this information regardless if "debug" is enabled. Print the debugging information if either the daemon, or the client has debug enabled.
We should probably improve this logic and print any of these if set (but some special rules are needed for file-descriptors, which may use "-1".
(cherry picked from commit 92d7a23)
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)