Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/command/container: remove deprecated NewStartOptions #4811

Merged

Conversation

thaJeztah
Copy link
Member

relates to:

This function was deprecated in 298bddc for v25.0, and unused. This patch removes the function.

- Description for the changelog

cli/command/container: remove deprecated `NewStartOptions()`

- A picture of a cute animal (not mandatory but encouraged)

This function was deprecated in 298bddc for
v25.0, and unused. This patch removes the function.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024

Codecov Report

Merging #4811 (2402dac) into master (f18a476) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4811   +/-   ##
=======================================
  Coverage   59.63%   59.63%           
=======================================
  Files         287      287           
  Lines       24777    24775    -2     
=======================================
  Hits        14775    14775           
+ Misses       9114     9112    -2     
  Partials      888      888           

@thaJeztah thaJeztah requested a review from a team January 22, 2024 20:33
Copy link
Contributor

@krissetto krissetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit ea84a3f into docker:master Jan 23, 2024
77 checks passed
@thaJeztah thaJeztah deleted the remove_deprecated_NewStartOptions branch January 23, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants