Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: drop explicit unlink #4963

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Commits on Mar 22, 2024

  1. plugin: drop explicit unlink

    Go's `net` package [will unlink][1] for us, as long as we used Listen &
    friends to create the Unix socket.
    
    Go will even skip the unlink when the socket appears to be abstract
    (starts with a NUL, represented by an @), though we must be cautious to
    only create sockets with an abstract address on platforms that actually
    support it -- this caused [several][2] [bugs][3] before.
    
      [1]: https://pkg.go.dev/net#UnixListener.SetUnlinkOnClose
      [2]: docker#4783
      [3]: docker#4863
    
    Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
    neersighted committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    509123f View commit details
    Browse the repository at this point in the history