-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify that --data-path-addr doesn't restrict access #4997
Conversation
cc @corhere |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4997 +/- ##
==========================================
- Coverage 61.04% 61.02% -0.03%
==========================================
Files 295 295
Lines 20648 20648
==========================================
- Hits 12605 12600 -5
- Misses 7147 7150 +3
- Partials 896 898 +2 |
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
c77e7a0
to
faf096b
Compare
Wondering if we should borrow some wording from cli/docs/reference/commandline/swarm_init.md Lines 95 to 109 in c23a404
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- What I did
Added a paragraph that clarifies the scope of the
--data-path-addr
fordocker swarm init
.Relates to moby/moby#47667
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)