Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[26.1 backport] cli-plugins: PluginRunCommand: use cmd.Environ instead of os.Environ #5047

Merged
merged 1 commit into from
Apr 30, 2024

Commits on Apr 30, 2024

  1. cli-plugins: PluginRunCommand: use cmd.Environ instead of os.Environ

    Commit 5011759 implemented a fix that
    caused the current environment to be discarded, using `os.Environ()`.
    On Windows, `os.Environ()` may produce an incorrect value for `PWD`,
    for which a new function was added in go1.19;
    
    - https://tip.golang.org/doc/go1.19#osexecpkgosexec
    - https://go-review.googlesource.com/c/go/+/401340
    
    Replace the use of `os.Environ()` with `cmd.Environ()` to address that.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    (cherry picked from commit 5ccb484)
    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    thaJeztah authored and vvoland committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1c6a8ec View commit details
    Browse the repository at this point in the history