-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralize init of Meter/TracerProviders #5067
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5067 +/- ##
==========================================
+ Coverage 61.09% 61.35% +0.26%
==========================================
Files 298 298
Lines 20675 20685 +10
==========================================
+ Hits 12631 12691 +60
+ Misses 7147 7093 -54
- Partials 897 901 +4 |
9c8b62d
to
0feb0dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0feb0dc
to
871f1b3
Compare
871f1b3
to
d0782f4
Compare
d0782f4
to
926613b
Compare
Chatted w/ @jsternberg, there's some other approaches that would be interesting to look at (take care of shutdown automatically in the CLI lifecycle), but he's okay with merging as-is for now to unblock releases and improving things later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I think we should have a log in case the typecast fails (so like panic, but without actually panicking), so we can be aware if our assumptions are broken with future OTEL updates.
Not a blocker if you think it's fine though.
…e them. Initialize them during DockerCli struct init Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
926613b
to
02537ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- What I did
Meter/TracerProvider
funcs onDockerCli
to return the providers rather than initialize them- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)