New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove secret/config duplication in cli/compose #671

Merged
merged 3 commits into from Nov 15, 2017

Conversation

Projects
None yet
5 participants
@dnephin
Collaborator

dnephin commented Nov 6, 2017

No description provided.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 6, 2017

Codecov Report

Merging #671 into master will increase coverage by 0.15%.
The diff coverage is 58.69%.

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   50.49%   50.64%   +0.15%     
==========================================
  Files         216      216              
  Lines       17723    17727       +4     
==========================================
+ Hits         8949     8978      +29     
+ Misses       8325     8296      -29     
- Partials      449      453       +4

codecov-io commented Nov 6, 2017

Codecov Report

Merging #671 into master will increase coverage by 0.15%.
The diff coverage is 58.69%.

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   50.49%   50.64%   +0.15%     
==========================================
  Files         216      216              
  Lines       17723    17727       +4     
==========================================
+ Hits         8949     8978      +29     
+ Misses       8325     8296      -29     
- Partials      449      453       +4
@vdemeester

LGTM 🐯

dnephin added some commits Nov 6, 2017

Remove duplication in loader
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Remove duplication in compose/convert
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Add unit tests for some convert/service
Signed-off-by: Daniel Nephin <dnephin@docker.com>

@dnephin dnephin requested a review from thaJeztah Nov 14, 2017

@thaJeztah

LGTM, nice 👍

@thaJeztah thaJeztah merged commit 801ddee into docker:master Nov 15, 2017

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch 58.69% of diff hit (target 50%)
Details
codecov/project 50.64% (+0.15%) compared to 70da09a
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.12.0 milestone Nov 15, 2017

@dnephin dnephin deleted the dnephin:remove-secret-config-duplication branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment