Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove secret/config duplication in cli/compose #671

Merged
merged 3 commits into from
Nov 15, 2017

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Nov 6, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 6, 2017

Codecov Report

Merging #671 into master will increase coverage by 0.15%.
The diff coverage is 58.69%.

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   50.49%   50.64%   +0.15%     
==========================================
  Files         216      216              
  Lines       17723    17727       +4     
==========================================
+ Hits         8949     8978      +29     
+ Misses       8325     8296      -29     
- Partials      449      453       +4

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin dnephin force-pushed the remove-secret-config-duplication branch 2 times, most recently from 3de9699 to f1cc679 Compare November 10, 2017 21:28
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice 👍

@thaJeztah thaJeztah merged commit 801ddee into docker:master Nov 15, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.12.0 milestone Nov 15, 2017
@dnephin dnephin deleted the remove-secret-config-duplication branch November 15, 2017 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants