New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go to 1.9.2 #716

Merged
merged 1 commit into from Nov 29, 2017

Conversation

Projects
None yet
5 participants
@vdemeester
Member

vdemeester commented Nov 29, 2017

Now that moby/moby#33892 is merged, we can update docker/cli to go 1.9.2 too 馃懠

馃惎 馃惢 馃

Signed-off-by: Vincent Demeester vincent@sbr.pm

Bump Go to 1.9.2
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@@ -1,3 +1,3 @@
FROM dockercore/golang-cross@sha256:25ff84377e9d7f40639c33cc374166a3b0f1829b8462cf7001d742a846de2687
FROM dockercore/golang-cross@sha256:2e843a0e4d82b6bab34d2cb7abe26d1a6cda23226ecc3869100c8db553603f9b

This comment has been minimized.

@vdemeester
@vdemeester

vdemeester Nov 29, 2017

Member

This one is https://hub.docker.com/r/dockercore/golang-cross/~/dockerfile/ 馃懠
cc @dnephin for tagging it 馃懠

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 29, 2017

Codecov Report

Merging #716 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
- Coverage   51.65%   51.64%   -0.01%     
==========================================
  Files         216      216              
  Lines       17860    17860              
==========================================
- Hits         9225     9224       -1     
- Misses       8159     8160       +1     
  Partials      476      476

codecov-io commented Nov 29, 2017

Codecov Report

Merging #716 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
- Coverage   51.65%   51.64%   -0.01%     
==========================================
  Files         216      216              
  Lines       17860    17860              
==========================================
- Hits         9225     9224       -1     
- Misses       8159     8160       +1     
  Partials      476      476
@thaJeztah

LGTM 鉂わ笍

@vdemeester

This comment has been minimized.

Show comment
Hide comment
@vdemeester

vdemeester Nov 29, 2017

Member

@dnephin I'm not sure why e2e failed on that one 馃

Member

vdemeester commented Nov 29, 2017

@dnephin I'm not sure why e2e failed on that one 馃

@dnephin

This comment has been minimized.

Show comment
Hide comment
@dnephin

dnephin Nov 29, 2017

Collaborator

The test is broken I think, I'll look at fixing it. Somehow the build output changed in 17.11 I think.

Collaborator

dnephin commented Nov 29, 2017

The test is broken I think, I'll look at fixing it. Somehow the build output changed in 17.11 I think.

@dnephin

LGTM

@dnephin dnephin merged commit 8abb266 into docker:master Nov 29, 2017

8 of 9 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 97b148b...6859a73
Details
codecov/project 51.64% (-0.01%) compared to 97b148b
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.12.0 milestone Nov 29, 2017

@vdemeester vdemeester deleted the vdemeester:bump-go branch Nov 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment