-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Go to 1.9.2 #716
Bump Go to 1.9.2 #716
Conversation
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@@ -1,3 +1,3 @@ | |||
FROM dockercore/golang-cross@sha256:25ff84377e9d7f40639c33cc374166a3b0f1829b8462cf7001d742a846de2687 | |||
FROM dockercore/golang-cross@sha256:2e843a0e4d82b6bab34d2cb7abe26d1a6cda23226ecc3869100c8db553603f9b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is https://hub.docker.com/r/dockercore/golang-cross/~/dockerfile/ 👼
cc @dnephin for tagging it 👼
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
- Coverage 51.65% 51.64% -0.01%
==========================================
Files 216 216
Lines 17860 17860
==========================================
- Hits 9225 9224 -1
- Misses 8159 8160 +1
Partials 476 476 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ❤️
@dnephin I'm not sure why e2e failed on that one 🤔 |
The test is broken I think, I'll look at fixing it. Somehow the build output changed in 17.11 I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Now that moby/moby#33892 is merged, we can update
docker/cli
to go 1.9.2 too 👼🐯 🐻 🦁
Signed-off-by: Vincent Demeester vincent@sbr.pm