Bump Go to 1.9.2 #716
Merged
Bump Go to 1.9.2 #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
commented
Nov 29, 2017
| @@ -1,3 +1,3 @@ | |||
| FROM dockercore/golang-cross@sha256:25ff84377e9d7f40639c33cc374166a3b0f1829b8462cf7001d742a846de2687 | |||
| FROM dockercore/golang-cross@sha256:2e843a0e4d82b6bab34d2cb7abe26d1a6cda23226ecc3869100c8db553603f9b | |||
There was a problem hiding this comment.
This one is https://hub.docker.com/r/dockercore/golang-cross/~/dockerfile/ 👼
cc @dnephin for tagging it 👼
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
- Coverage 51.65% 51.64% -0.01%
==========================================
Files 216 216
Lines 17860 17860
==========================================
- Hits 9225 9224 -1
- Misses 8159 8160 +1
Partials 476 476 |
|
@dnephin I'm not sure why e2e failed on that one 🤔 |
|
The test is broken I think, I'll look at fixing it. Somehow the build output changed in 17.11 I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that moby/moby#33892 is merged, we can update
docker/clito go 1.9.2 too 👼🐯 🐻 🦁
Signed-off-by: Vincent Demeester vincent@sbr.pm