Add support for read_only services in stack deploy
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
approved these changes
May 11, 2017
dnephin
suggested changes
May 11, 2017
The `read_only` key in a composefile is not taken into account right now. Now that services support `--read-only`, so should `stack deploy` Ref: moby/moby#32994 Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
stack-deploy-support-readonly
branch
from
e5fac26
to
0ab760a
Compare
|
@dnephin updated 👼 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
read_onlykey in a composefile is not taken into account rightnow. Now that services support
--read-only, so shouldstack deployRef: moby/moby#32994
🦁
Signed-off-by: Vincent Demeester vincent@sbr.pm