New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for `read_only` services in stack deploy #73

Merged
merged 1 commit into from May 11, 2017

Conversation

Projects
None yet
5 participants
@vdemeester
Member

vdemeester commented May 11, 2017

The read_only key in a composefile is not taken into account right
now. Now that services support --read-only, so should stack deploy

Ref: moby/moby#32994

馃

Signed-off-by: Vincent Demeester vincent@sbr.pm

@thaJeztah

LGTM

apparenty it was already in the compose-file schema 馃槄

@dnephin

You'll need to remove it from UnsupportedProperties in cli/compose/types/types.go as well. I guess the tests are still passing because it's just printing a warning.

Add support for `read_only` services in stack deploy
The `read_only` key in a composefile is not taken into account right
now. Now that services support `--read-only`, so should `stack deploy`

Ref: moby/moby#32994

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester

This comment has been minimized.

Show comment
Hide comment
@vdemeester

vdemeester May 11, 2017

Member

@dnephin updated 馃懠

Member

vdemeester commented May 11, 2017

@dnephin updated 馃懠

@dnephin

LGTM when green

@diogomonica

This comment has been minimized.

Show comment
Hide comment
@diogomonica

diogomonica May 11, 2017

Contributor

LGTM

Contributor

diogomonica commented May 11, 2017

LGTM

@dnephin dnephin merged commit c0cbb65 into docker:master May 11, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
dco-signed All commits are signed

@vdemeester vdemeester deleted the vdemeester:stack-deploy-support-readonly branch May 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment