[Carry moby/moby#32777] Adjusted docker stats memory output #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
reviewed
May 15, 2017
| // Then | ||
| if !float64Equals(result, expected) { | ||
| t.Errorf("mem = %f, want %f", result, expected) | ||
| } |
There was a problem hiding this comment.
https://godoc.org/github.com/stretchr/testify/assert#InEpsilon
That way you don't have to create float64Equals()
Signed-off-by: Sergey Tryuber <Sergeant007@users.noreply.github.com> Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
AkihiroSuda
force-pushed
the
adjust-docker-stats
branch
from
060628d
to
3c78bc7
Compare
|
done |
|
looks like we have enough LGTM's, and CI is 💚 |
runcom
added a commit
to projectatomic/docker
that referenced
this pull request
Jul 13, 2017
Upstream reference: docker/cli#80 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1470640 Signed-off-by: Antonio Murdaca <runcom@redhat.com>
runcom
added a commit
to projectatomic/docker
that referenced
this pull request
Jul 13, 2017
Upstream reference: docker/cli#80 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1470640 Signed-off-by: Antonio Murdaca <runcom@redhat.com>
runcom
added a commit
to projectatomic/docker
that referenced
this pull request
Jul 13, 2017
Upstream reference: docker/cli#80 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1470640 Signed-off-by: Antonio Murdaca <runcom@redhat.com>
This was referenced Jul 27, 2017
|
why not add one more column to show the "cache" used by this container |
runcom
added a commit
to projectatomic/docker
that referenced
this pull request
Jul 5, 2018
Upstream reference: docker/cli#80 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1470640 Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carry moby/moby#32777 (comment)
cc @Sergeant007
Signed-off-by: Sergey Tryuber Sergeant007@users.noreply.github.com
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp