Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carry moby/moby#32777] Adjusted docker stats memory output #80

Merged
merged 2 commits into from May 17, 2017

Conversation

@AkihiroSuda
Copy link
Member

commented May 13, 2017

Carry moby/moby#32777 (comment)

cc @Sergeant007

Signed-off-by: Sergey Tryuber Sergeant007@users.noreply.github.com
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp

// Then
if !float64Equals(result, expected) {
t.Errorf("mem = %f, want %f", result, expected)
}

This comment has been minimized.

Copy link
@dnephin

dnephin May 15, 2017

Collaborator

https://godoc.org/github.com/stretchr/testify/assert#InEpsilon

That way you don't have to create float64Equals()

Sergeant007 and others added 2 commits Apr 27, 2017
Adjusted docker stats memory output
Signed-off-by: Sergey Tryuber <Sergeant007@users.noreply.github.com>
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Fix float64 comparison in stats_helpers_test.go
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>

@AkihiroSuda AkihiroSuda force-pushed the AkihiroSuda:adjust-docker-stats branch from 060628d to 3c78bc7 May 16, 2017

@AkihiroSuda

This comment has been minimized.

Copy link
Member Author

commented May 16, 2017

done

@dnephin
Copy link
Collaborator

left a comment

LGTM

@vdemeester
Copy link
Member

left a comment

LGTM 🐯

@thaJeztah

This comment has been minimized.

Copy link
Member

commented May 17, 2017

looks like we have enough LGTM's, and CI is 💚

@thaJeztah thaJeztah merged commit 85c2330 into docker:master May 17, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.06.0 milestone May 17, 2017

runcom added a commit to projectatomic/docker that referenced this pull request Jul 13, 2017
BACKPORT: Adjusted docker stats memory output
Upstream reference: docker/cli#80
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1470640

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
runcom added a commit to projectatomic/docker that referenced this pull request Jul 13, 2017
BACKPORT: Adjusted docker stats memory output
Upstream reference: docker/cli#80
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1470640

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
runcom added a commit to projectatomic/docker that referenced this pull request Jul 13, 2017
BACKPORT: Adjusted docker stats memory output
Upstream reference: docker/cli#80
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1470640

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@taodd

This comment has been minimized.

Copy link

commented Nov 17, 2017

why not add one more column to show the "cache" used by this container

runcom added a commit to projectatomic/docker that referenced this pull request Jul 5, 2018
BACKPORT: Adjusted docker stats memory output
Upstream reference: docker/cli#80
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1470640

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.