Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Golang to 1.9.5 #986

Merged
merged 1 commit into from Apr 5, 2018
Merged

Conversation

thaJeztah
Copy link
Member

go1.9.5 (released 2018/03/28) includes fixes to the compiler, go command, and net/http/pprof package. See the Go 1.9.5 milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.9.5

@@ -1,3 +1,3 @@
FROM dockercore/golang-cross:1.9.4@sha256:b8d43ef11ccaa15bec63a1f1fd0c28a0e729074aa62fcfa51f0a5888f3571315
FROM dockercore/golang-cross:latest@sha256:9e626f4ed30718deb2f8dd6b36c454ff11cbb5c9900f971ebfe37582fd0d5a72
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't have push access to the repo, so couldn't tag it as 1.9.5 😊

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, 1.9.5 pushed 😉

@thaJeztah
Copy link
Member Author

ping @cpuguy83 @vdemeester @tibor

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go1.9.5 (released 2018/03/28) includes fixes to the compiler, go command, and
net/http/pprof package. See the Go 1.9.5 milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.9.5

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Updated to use the tagged image: dockercore/golang-cross:1.9.5@sha256:4d090b8c2e6d369a48254c882a4e653ba90caaa0b758105da772d9110394d958

@vdemeester vdemeester merged commit fe83fee into docker:master Apr 5, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.04.0 milestone Apr 5, 2018
@thaJeztah thaJeztah deleted the bump-golang-1.9.5 branch April 5, 2018 21:00
@thaJeztah thaJeztah modified the milestones: 18.04.0, 18.05.0 Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants