Skip to content
This repository has been archived by the owner on Mar 11, 2020. It is now read-only.

Consolidate Windows Server Feature discovery into a single artifact #3

Closed
sixeyed opened this issue Sep 14, 2016 · 2 comments
Closed
Labels
Milestone

Comments

@sixeyed
Copy link
Contributor

sixeyed commented Sep 14, 2016

@pcgeek86 is there a reason for having multiple Discover/Generate steps, each for an explicit Windows Feature? Could we have a generic step that discovers all installed features with Get-WindowsFeature ... | Where Installed and a generic generate which does Add-WindowsFeature for all the installed features?

I think those commands are also available for 2008R2 so potentially gives the tool a wider reach.

@pcgeek86
Copy link
Contributor

@sixeyed Good question. There are certainly multiple ways of approaching this. However, certain Windows Features actually have deeper configuration that goes into them.

Right now, I see a couple of different options available to move forward:

  • Option 1: Generalize all Windows Server Features as a single artifact
  • Option 2: Keep Windows Server Features as separate artifacts, and include deeper inspection of each Windows Server Feature in its corresponding artifact.

What do you think?

@sixeyed
Copy link
Contributor Author

sixeyed commented Sep 14, 2016

I would incline to do both. Option 1 gives a lot of value quickly with a
horizontal sweep. Then we can add more depth incrementally with new
features - IIS website setup, MSMQ queues etc, which we could prioritise
separately.

Also I think listing all the features in one hit in the Dockerfile puts
users in a good place to trim out anything they're not using.

On 14 Sep 2016 17:33, "Trevor Sullivan" notifications@github.com wrote:

@sixeyed https://github.com/sixeyed Good question. There are certainly
multiple ways of approaching this. However, certain Windows Features
actually have deeper configuration that goes into them.

Right now, I see a couple of different options available to move forward:

  • Option 1: Generalize all Windows Server Features as a single
    artifact
  • Option 2: Keep Windows Server Features as separate artifacts, and
    include deeper inspection of each Windows Server Feature in its
    corresponding artifact.

What do you think?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJm5fQ1XcaN0DMSjggmEVvOOVzjAVOQks5qqCHxgaJpZM4J8ffD
.

@pcgeek86 pcgeek86 changed the title Generalise all Windows features Consolidate Windows Server Feature discovery into a single artifact Sep 14, 2016
kilasuit added a commit to kilasuit/communitytools-image2docker-win that referenced this issue Dec 2, 2016
@sixeyed sixeyed added this to the 1.5.1 milestone Dec 5, 2016
@sixeyed sixeyed closed this as completed Dec 5, 2016
ManoMarks pushed a commit that referenced this issue Dec 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants