-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hint about OS X binary compatibility #1779
Conversation
@@ -43,6 +43,8 @@ Compose can also be installed as a Python package: | |||
No further steps are required; Compose should now be successfully installed. | |||
You can test the installation by running `docker-compose --version`. | |||
|
|||
> Note: If you get an error like "Illegal instruction: 4" after installing using the binary on Mac OS X, your CPU architecture isn't supported and you should install using Pip instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aanand move this note after the paragraph/sentence starting "Optionally,..."
Change Note: formatting and contents to
Note: Some older Mac OS X CPU architectures are incompatible with installing the binary using curl
. If you receive an "Illegal instruction: 4" error after installing using curl
, you should install using the pip
command instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
b81ac20
to
4d1f478
Compare
LGTM, thx |
👍 |
@moxiegirl My only problem with this wording is it might imply that |
@aanand yeah, you have a point now that I read it. If you remove "with curl" I'm cool. LGTM |
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
4d1f478
to
b08e23d
Compare
Add hint about OS X binary compatibility
Add hint about OS X binary compatibility (cherry picked from commit 1496734) Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
As reported by many people in #271, older Macs have trouble with the Compose binary. I've added a hint to the install instructions directing them to install using Pip instead.
ping @moxiegirl