Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint about OS X binary compatibility #1779

Merged
merged 1 commit into from
Jul 29, 2015

Conversation

aanand
Copy link

@aanand aanand commented Jul 28, 2015

As reported by many people in #271, older Macs have trouble with the Compose binary. I've added a hint to the install instructions directing them to install using Pip instead.

ping @moxiegirl

@@ -43,6 +43,8 @@ Compose can also be installed as a Python package:
No further steps are required; Compose should now be successfully installed.
You can test the installation by running `docker-compose --version`.

> Note: If you get an error like "Illegal instruction: 4" after installing using the binary on Mac OS X, your CPU architecture isn't supported and you should install using Pip instead.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aanand move this note after the paragraph/sentence starting "Optionally,..."

Change Note: formatting and contents to

Note: Some older Mac OS X CPU architectures are incompatible with installing the binary using curl. If you receive an "Illegal instruction: 4" error after installing using curl, you should install using the pip command instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@aanand aanand force-pushed the mac-binary-error-hint branch 3 times, most recently from b81ac20 to 4d1f478 Compare July 28, 2015 16:02
@thaJeztah
Copy link
Member

LGTM, thx

@josephpage
Copy link

👍

@aanand
Copy link
Author

aanand commented Jul 28, 2015

@moxiegirl My only problem with this wording is it might imply that curl is the problem, not the binary. Do you think that's an issue?

@moxiegirl
Copy link

@aanand yeah, you have a point now that I read it. If you remove "with curl" I'm cool. LGTM

Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand added a commit that referenced this pull request Jul 29, 2015
Add hint about OS X binary compatibility
@aanand aanand merged commit 1496734 into docker:master Jul 29, 2015
@aanand aanand deleted the mac-binary-error-hint branch July 29, 2015 14:06
aanand added a commit to aanand/fig that referenced this pull request Jul 31, 2015
Add hint about OS X binary compatibility
(cherry picked from commit 1496734)

Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants