Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning not to use build:args for secrets #3999

Closed
Binarytales opened this issue Oct 3, 2016 · 2 comments
Closed

Warning not to use build:args for secrets #3999

Binarytales opened this issue Oct 3, 2016 · 2 comments
Labels

Comments

@Binarytales
Copy link

Binarytales commented Oct 3, 2016

Assuming that

build:
    args:
        - key=token

is analogous to --build-arg <varname>=<value> command line option and it's realtion opt the ARG command in a Dockerfile, should the documentation not include the same warning about not using this to pass secrets as seen in the Dockerfile documentation:

https://docs.docker.com/engine/reference/builder/#/arg

Related PR/Issue: moby/moby#24522

That the example uses password:secret seems particularly egregious if my assumption is correct.

If somebody can clarify my assumption in the affirmative I'll open a PR to update the examples and add the same wording as a warning from PR linked above.

@stale
Copy link

stale bot commented Oct 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 10, 2019
@stale
Copy link

stale bot commented Oct 17, 2019

This issue has been automatically closed because it had not recent activity during the stale period.

@stale stale bot closed this as completed Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant