Clarify warning against using build-time variables for secrets #24522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current docs for the Dockerfile
ARG
instruction contain a note recommending against using build-time variables for passing secrets, but they don't explain why.I've attempted to clarify the reasoning without going into too much detail, and I've upgraded the
Note
to aWarning
.Signed-off-by: Dave Henderson dhenderson@gmail.com