New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker compose healthcheck on lcow #6445
Comments
I believe this is an engine issue. cc @thaJeztah Looks like this doesn't account for possible LCOW setups. |
@shin Thank you. I kind of thought this might be an engine issue. |
+1, unfortunately still encountering this issue on Docker 18.09.6 Win 2019 Server with latest LCOW kernel |
As reported in docker/compose#6445, when deploying a Linux container on Windows (LCOW), the daemon made the wrong assumption when deciding which shell to use to execute the healthcheck, looking at the host's platform instead of the container's platform. This patch adds a check for the container's platform when deploying on Windows, and sets the correct shell. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Opened moby/moby#39389, which I think should fix this |
As reported in docker/compose#6445, when deploying a Linux container on Windows (LCOW), the daemon made the wrong assumption when deciding which shell to use to execute the healthcheck, looking at the host's platform instead of the container's platform. This patch adds a check for the container's platform when deploying on Windows, and sets the correct shell. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 3e6a13ccb8ec1395d46925bc4c075cb32cf395a6 Component: engine
As reported in docker/compose#6445, when deploying a Linux container on Windows (LCOW), the daemon made the wrong assumption when deciding which shell to use to execute the healthcheck, looking at the host's platform instead of the container's platform. This patch adds a check for the container's platform when deploying on Windows, and sets the correct shell. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: zach <Zachary.Joyner@linux.com>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it had not recent activity during the stale period. |
As reported in docker/compose#6445, when deploying a Linux container on Windows (LCOW), the daemon made the wrong assumption when deciding which shell to use to execute the healthcheck, looking at the host's platform instead of the container's platform. This patch adds a check for the container's platform when deploying on Windows, and sets the correct shell. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 3e6a13c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Docker compose can't execute container healthcheck when running windows docker engine with lcow enabled
It seams that healthcheck test command completely ignores platform option from service configuration, no matter, the command syntax you use.
Output of
docker-compose version
Output of
docker version
Output of
docker-compose config
(Make sure to add the relevant
-f
and other flags)Observed result
Healthcheck fails
Expected result
Healthcheck passes
Stacktrace / full error message
Additional information
Windows Server Datacenter 6.3, Server Core, Build 1709
The text was updated successfully, but these errors were encountered: