Remove Python2 #6890

ulyssessouza · 2019-09-09T14:14:52Z

Is your feature request related to a problem? Please describe.
As January 1st approaches, support for "Python 2" gets to its end. By deprecating it we can free some machine/time on CI and maybe simplify our "dependency matrix"

Note that this issue is not meant to be executed before the January 1st 2020. The early public issue is just to track it and talk/communicate about.

Describe the solution you'd like

Remove py2 from the build matrix in Jenkins
Remove Python 2 from setup.py
Remove six from requirements.txt
Remove the announcement banner in README.md

The text was updated successfully, but these errors were encountered:

funkyfuture · 2019-09-11T10:20:27Z

two quick remarks:

dropping support for Python 2 also allows to employ language features for better readability, like dict comprehensions, set literals; new-style classes should be used and might provide leverage for further improvements.
why would the support for Python 2.7 be dropped when Python 3.2 and 3.4 is still supported though they reached their eol.

ulyssessouza · 2019-09-11T11:20:33Z

@funkyfuture I agree with the first remark, and for the second, I don't see any problem on dropping that.
The point here is just that dropping 3.2 and 3.4 will just impact the setup.py and not the compose code itself, like removing all the six conditions inside the code that would be a fairly big PR

Closes: docker#6890 Signed-off-by: Bastian Venthur <bastian.venthur@flixbus.com>

see docker#6890 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

see #6890 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

Closes: docker#6890 Signed-off-by: Bastian Venthur <bastian.venthur@flixbus.com>

agronholm · 2019-11-30T11:33:56Z

dropping support for Python 2 also allows to employ language features for better readability, like dict comprehensions, set literals; new-style classes should be used and might provide leverage for further improvements.

I'm not arguing against dropping Python 2 support, but all of these language features are already supported on Python 2.

ndeloof · 2019-11-30T11:55:34Z

There's probably many places a pure python 3 codebase could offer improvements, but my main motivation here is to reduce the maintenance effort.

SuperSandro2000 · 2019-11-30T15:24:42Z

and Python 2.7 is EOL and is going to be removed from the next Debian and Ubuntu releases.

see #6890 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

DeeDeeG · 2020-03-05T15:05:02Z

Hi,

Remove the announcement banner in README.md

I think it could be worthwhile to leave this as a deprecation notice for some time after the change, so folks with broken python support who come here can know what's up (that this is intentional, etc.)

Otherwise all sounds reasonable to me. 👍

Edit: Or you could pin this issue. Just something to avoid issue spam and to give clarity to the situation.

Edit 2:

Python 2.7 is EOL and is going to be removed from the next Debian and Ubuntu releases.

Not strictly true. The executable named python is being removed, by default, from fresh installs of Ubuntu, but upgrades of prior distros are planned to have python2 still installed as the default Python. It is also runnable (for upgrades from earlier Ubuntu versions) as python, via a symlink. But for fresh Focal installs, one needs to run python2 or python3 explicitly, and there is no program named exactly "python".

See:

https://lists.ubuntu.com/archives/ubuntu-devel/2020-January/040869.html
- https://lists.ubuntu.com/archives/ubuntu-devel/2020-January/040882.html
https://lists.ubuntu.com/archives/ubuntu-devel/2020-February/040918.html
- 20.04 LTS will ship python2. [Those] who cannot port some
  applications are able to use python2 for the 20.04 LTS release.

---- Downgrade gitpython to 2.1.15 and idna to 2.8 Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com> Removed Python2 support Closes: docker#6890 Signed-off-by: Bastian Venthur <bastian.venthur@flixbus.com> Removed six Signed-off-by: Bastian Venthur <bastian.venthur@flixbus.com>

---- Downgrade gitpython to 2.1.15 and idna to 2.8 Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com> Removed Python2 support Closes: docker#6890 Signed-off-by: Bastian Venthur <bastian.venthur@flixbus.com> Removed six Signed-off-by: Bastian Venthur <bastian.venthur@flixbus.com> Removed now useless check for version_info >= 2.7 Signed-off-by: Bastian Venthur <bastian.venthur@flixbus.com> Removed now unused get_output_stream method Signed-off-by: Bastian Venthur <bastian.venthur@flixbus.com> Import unittest.mock directly. We don't need to support Python2 anymore. Signed-off-by: Bastian Venthur <bastian.venthur@flixbus.com>

---- Downgrade gitpython to 2.1.15 and idna to 2.8 Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com> Removed Python2 support Closes: docker#6890 - Removed six - Removed now useless check for version_info >= 2.7 - Removed now unused get_output_stream method - Import unittest.mock directly. How we removed six from docker-compose We expect this to happen in a couple steps, 1. Remove six entirely, and remove python2.7 from requirements, setup, etc. 2. cleanup code that is left (All the conditionals that are now always True or False) 3. Remove all unnecessary `__future__` commands, by modifying the pre-commit-hook of python sourts to be `--py3-plus` After removing all occurrances, we made sure `six` wasn't used anymore running a search for ```txt six\.\w+\(([^()]+)\) ``` - We replaced all types for their corresponding python3 types. Note how six returns a tuple for the isinstance (since in python2 there are more than one type, but that isn't necessary in python3, so we removed the tuple and instead used the class directly) We then searched for all instances where code could be pruned. (i.e., if/else clauses that now where always `True` or `False`) After that, - Removed inheritinng from `object` super class, it isn't necessary in python3 - `# coding ... utf-8` statements are not needed - `super(ClassName, self)` can now be replaced with `super()`

---- Removed Python2 support Closes: docker#6890 - Removed six - Removed now useless check for version_info >= 2.7 - Removed now unused get_output_stream method - Import unittest.mock directly. How we removed six from docker-compose We expect this to happen in a couple steps, 1. Remove six entirely, and remove python2.7 from requirements, setup, etc. 2. cleanup code that is left (All the conditionals that are now always True or False) 3. Remove all unnecessary `__future__` commands, by modifying the pre-commit-hook of python sourts to be `--py3-plus` After removing all occurrances, we made sure `six` wasn't used anymore running a search for ```txt six\.\w+\(([^()]+)\) ``` - We replaced all types for their corresponding python3 types. Note how six returns a tuple for the isinstance (since in python2 there are more than one type, but that isn't necessary in python3, so we removed the tuple and instead used the class directly) We then searched for all instances where code could be pruned. (i.e., if/else clauses that now where always `True` or `False`) After that, - Removed inheritinng from `object` super class, it isn't necessary in python3 - `# coding ... utf-8` statements are not needed - `super(ClassName, self)` can now be replaced with `super()` Signed-off-by: Alejandro G. Recuenco <alejandrogonzalezrecuenco@gmail.com>

---- Removed Python2 support Closes: docker#6890 - Removed six - Removed now useless check for version_info >= 2.7 - Removed now unused get_output_stream method - Import unittest.mock directly. How we removed six from docker-compose We expect this to happen in a couple steps, 1. Remove six entirely, and remove python2.7 from requirements, setup, etc. 2. cleanup code that is left (All the conditionals that are now always True or False) 3. Remove all unnecessary `__future__` commands, by modifying the pre-commit-hook of python sourts to be `--py3-plus` After removing all occurrances, we made sure `six` wasn't used anymore running a search for ```txt six\.\w+\(([^()]+)\) ``` - We replaced all types for their corresponding python3 types. Note how six returns a tuple for the isinstance (since in python2 there are more than one type, but that isn't necessary in python3, so we removed the tuple and instead used the class directly) We then searched for all instances where code could be pruned. (i.e., if/else clauses that now where always `True` or `False`) After that, - Removed inheritinng from `object` super class, it isn't necessary in python3 - `# coding ... utf-8` statements are not needed - `super(ClassName, self)` can now be replaced with `super()` Signed-off-by: alexrecuenco <alejandrogonzalezrecuenco@gmail.com>

---- Removed Python2 support Closes: docker#6890 - Removed six - Removed now useless check for version_info >= 2.7 - Removed now unused get_output_stream method - Import unittest.mock directly. Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>

Closes: docker#6890 Signed-off-by: Bastian Venthur <bastian.venthur@flixbus.com>

Closes: docker#6890 Some remarks, - `# coding ... utf-8` statements are not needed - isdigit on strings instead of a try-catch. - Default opening mode is read, so we can do `open()` without the `'r'` everywhere - Removed inheritinng from `object` class, it isn't necessary in python3. - `super(ClassName, self)` can now be replaced with `super()` - Use of itertools and `chain` on a couple places dealing with sets. - Used the operator module instead of lambdas when warranted `itemgetter(0)` instead of `lambda x: x[0]` `attrgetter('name')` instead of `lambda x: x.name` - `sorted` returns a list, so no need to use `list(sorted(...))` - Removed `dict()` using dictionary comprehensions whenever possible - Attempted to remove python3.2 support Signed-off-by: alexrecuenco <alejandrogonzalezrecuenco@gmail.com>

Closes: #6890 Some remarks, - `# coding ... utf-8` statements are not needed - isdigit on strings instead of a try-catch. - Default opening mode is read, so we can do `open()` without the `'r'` everywhere - Removed inheritinng from `object` class, it isn't necessary in python3. - `super(ClassName, self)` can now be replaced with `super()` - Use of itertools and `chain` on a couple places dealing with sets. - Used the operator module instead of lambdas when warranted `itemgetter(0)` instead of `lambda x: x[0]` `attrgetter('name')` instead of `lambda x: x.name` - `sorted` returns a list, so no need to use `list(sorted(...))` - Removed `dict()` using dictionary comprehensions whenever possible - Attempted to remove python3.2 support Signed-off-by: alexrecuenco <alejandrogonzalezrecuenco@gmail.com>

This was referenced Oct 21, 2019

Running docker-compose on python3 would work better tiangolo/docker-with-compose#7

Closed

Logs stop consuming for container, blocking writes to stderr #6018

Closed

ndeloof mentioned this issue Oct 30, 2019

Fixed non-ascii error when using COMPOSE_DOCKER_CLI_BUILD=1 for Buildkit #6982

Merged

chris-crone added this to the 1.25.0 milestone Oct 30, 2019

ulyssessouza modified the milestones: 1.25.0, 1.26.0 Nov 14, 2019

venthur added a commit to venthur/compose that referenced this issue Nov 19, 2019

Removed Python2 support

d94c0da

Closes: docker#6890 Signed-off-by: Bastian Venthur <bastian.venthur@flixbus.com>

venthur mentioned this issue Nov 19, 2019

Removed Python2 support #7031

Merged

ndeloof added a commit to ndeloof/compose that referenced this issue Nov 19, 2019

Prepare drop of python 2.x support

c4acf41

see docker#6890 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

ndeloof mentioned this issue Nov 19, 2019

Prepare drop of python 2.x support #7034

Closed

ndeloof added a commit that referenced this issue Nov 20, 2019

Prepare drop of python 2.x support

9ad1057

see #6890 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

ndeloof pushed a commit to venthur/compose that referenced this issue Nov 20, 2019

Removed Python2 support

4b0521c

Closes: docker#6890 Signed-off-by: Bastian Venthur <bastian.venthur@flixbus.com>

ulyssessouza changed the title ~~Deprecate Python2~~ Remove Python2 Nov 21, 2019

ndeloof added the kind/epic label Nov 21, 2019

jamshid mentioned this issue Nov 22, 2019

pip install docker-compose==1.25 fails due to lack of python headers for building subprocess32 #7030

Closed

ndeloof added a commit that referenced this issue Dec 6, 2019

Prepare drop of python 2.x support

8c602a9

see #6890 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

ndeloof added a commit that referenced this issue Jan 8, 2020

Prepare drop of python 2.x support

ba728ab

see #6890 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

ndeloof added a commit that referenced this issue Jan 8, 2020

Prepare drop of python 2.x support

dd889b9

see #6890 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

ollisal mentioned this issue Jan 8, 2020

python3 support tmaier/docker-compose#11

Closed

alexrecuenco mentioned this issue Mar 14, 2020

Clean up python2 style code #7294

Merged

venthur added a commit to venthur/compose that referenced this issue Jun 3, 2020

Removed Python2 support

e8424d5

Closes: docker#6890 Signed-off-by: Bastian Venthur <bastian.venthur@flixbus.com>

ulyssessouza closed this as completed in #7031 Jun 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Python2 #6890

Remove Python2 #6890

ulyssessouza commented Sep 9, 2019 •

edited

Loading

funkyfuture commented Sep 11, 2019

ulyssessouza commented Sep 11, 2019

agronholm commented Nov 30, 2019

ndeloof commented Nov 30, 2019

SuperSandro2000 commented Nov 30, 2019

DeeDeeG commented Mar 5, 2020 •

edited

Loading

Remove Python2 #6890

Remove Python2 #6890

Comments

ulyssessouza commented Sep 9, 2019 • edited Loading

funkyfuture commented Sep 11, 2019

ulyssessouza commented Sep 11, 2019

agronholm commented Nov 30, 2019

ndeloof commented Nov 30, 2019

SuperSandro2000 commented Nov 30, 2019

DeeDeeG commented Mar 5, 2020 • edited Loading

ulyssessouza commented Sep 9, 2019 •

edited

Loading

DeeDeeG commented Mar 5, 2020 •

edited

Loading