[Feature Request] "convert --images" list only built images #8994

abdennour · 2021-12-04T04:27:01Z

Description

docker compose convert --images list all images.
This feature request is about listing only built images not all of them

Proposal

Option 1
- Overview
  Adding another flag for the subcommand convert called "--built-images"
- Sample(s)
  docker compose convert --built-images
- Advantages over other options
  Dedicated flag for a unique purpose
Option 2
- Overview
  Adding another flag for the subcommand convert called "--only-built" to be used alongside with the current flag "--images"
- Sample(s)
  docker compose convert --images --only-built
- Advantages over other options
  the new flag "--only-built" becomes as filter for any convert subcommand ( not only images)

Please let me know which one do you prefer and i can open PR for that

The text was updated successfully, but these errors were encountered:

abdennour · 2021-12-04T09:32:51Z

Please let me know which one do you prefer and i can open PR
@mat007 @glours @ndeloof PFYI

Ability to filter images by services which uses built images It solves docker#8994 ( option 2 ) Signed-off-by: abdennour <mail@abdennoor.com>

Ability to filter images by services which uses built images It solves docker#8994 ( option 2 ) Signed-off-by: abdennour <mail@abdennoor.com> Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

ndeloof · 2021-12-04T11:02:23Z

My preference goes to

introduce actual subcommand compose config images
have this new subcommand declare its own flags. In terms of UX I'd prefer a simpler --built but that's to be debated
deprecate --images and redirect to this new subcommand
(do the same for other pseudo-commands in the config command for UX homogeneity

abdennour · 2021-12-04T12:00:15Z

I like it! but what if this can be global option for the whole CLI (filter services) ?!
As you mentioned for --built, it should be debated. indeed, what if i want to render the opposite : ready/pulled images only.
@ndeloof So that option should cover:

all images (binary opt value: 11)
only built images (binary opt value : 01)
only ready images (binary opt value: 10) ( all images - only built images)

abdennour · 2021-12-04T17:34:24Z

can we go agile : releasing config --built-images , then think about refactoring/re-organizing? @ndeloof

More details here: #8995 (comment)

It solves docker#8994 Signed-off-by: abdennour <mail@abdennoor.com>

abdennour · 2021-12-06T06:32:16Z

@ndeloof i am still thinking with you.
This is another design:

BUILT_SERVICES=$(docker compose config --built-services) ( new option here to be released)
then: docker compose config --images $BUILT_SERVICES ( no change here )

But honestly, i would like to be a single command.

abdennour · 2021-12-10T10:01:46Z

Reminder @ndeloof !

abdennour · 2021-12-17T17:45:15Z

I just realized that you already use the terminology imagesToBuild

compose/pkg/compose/build.go

Line 51 in 381df20

imagesToBuild := []string{}

I will rename --built-images to --images-to-build , and after that, i think it's acceptable and the related PR #8995 can be merged

@ndeloof @glours FYI

it solves docker#8994

it solves docker#8994 Signed-off-by: abdennour <mail@abdennoor.com>

Ability to filter images by services which uses built images It solves docker#8994 ( option 2 ) Signed-off-by: abdennour <mail@abdennoor.com> Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: abdennour <mail@abdennoor.com>

It solves docker#8994 Signed-off-by: abdennour <mail@abdennoor.com>

Ability to filter images by services which uses built images It solves docker#8994 ( option 2 ) Signed-off-by: abdennour <mail@abdennoor.com> Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: abdennour <mail@abdennoor.com>

It solves docker#8994 Signed-off-by: abdennour <mail@abdennoor.com>

abdennour · 2021-12-19T08:42:40Z

@glours Kindly reminder
@ndeloof

Ability to filter images by services which uses built images It solves docker#8994 ( option 2 ) Signed-off-by: abdennour <mail@abdennoor.com> Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

It solves docker#8994 Signed-off-by: abdennour <mail@abdennoor.com>

it solves docker#8994 Signed-off-by: abdennour <mail@abdennoor.com>

stale · 2022-07-10T12:22:55Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2022-11-02T05:33:26Z

This issue has been automatically closed because it had not recent activity during the stale period.

abdennour changed the title ~~Feature Request - convert --built-images to list only built images~~ [Feature Request] "convert --images" list only built images Dec 4, 2021

abdennour added a commit to ElmCompany/compose that referenced this issue Dec 4, 2021

introduce config --images --only-built

fcb774a

Ability to filter images by services which uses built images It solves docker#8994 ( option 2 ) Signed-off-by: abdennour <mail@abdennoor.com>

abdennour mentioned this issue Dec 4, 2021

introduce config --images-to-build #8995

Open

abdennour mentioned this issue Dec 4, 2021

introduce config --images --only-built ElmCompany/compose#1

Merged

abdennour added a commit to ElmCompany/compose that referenced this issue Dec 4, 2021

introduce config --built-images

accadb0

It solves docker#8994 Signed-off-by: abdennour <mail@abdennoor.com>

abdennour mentioned this issue Dec 4, 2021

introduce config --built-images ElmCompany/compose#2

Merged

abdennour added a commit to ElmCompany/compose that referenced this issue Dec 4, 2021

introduce config --built-images

6b87c11

It solves docker#8994 Signed-off-by: abdennour <mail@abdennoor.com>

abdennour added a commit to ElmCompany/compose that referenced this issue Dec 17, 2021

refactor(config): introduce --images-to-build

c4cb979

it solves docker#8994

abdennour added a commit to ElmCompany/compose that referenced this issue Dec 17, 2021

refactor(config): introduce --images-to-build

7020503

it solves docker#8994 Signed-off-by: abdennour <mail@abdennoor.com>

abdennour mentioned this issue Dec 17, 2021

refactor(config): introduce --images-to-build ElmCompany/compose#3

Merged

abdennour added a commit to ElmCompany/compose that referenced this issue Dec 18, 2021

introduce config --built-images

091413e

It solves docker#8994 Signed-off-by: abdennour <mail@abdennoor.com>

abdennour added a commit to ElmCompany/compose that referenced this issue Dec 18, 2021

introduce config --built-images

9ef5453

It solves docker#8994 Signed-off-by: abdennour <mail@abdennoor.com>

abdennour added a commit to ElmCompany/compose that referenced this issue Jan 17, 2022

introduce config --built-images

a0fcd6a

It solves docker#8994 Signed-off-by: abdennour <mail@abdennoor.com>

abdennour added a commit to ElmCompany/compose that referenced this issue Jan 17, 2022

refactor(config): introduce --images-to-build

4223ade

it solves docker#8994 Signed-off-by: abdennour <mail@abdennoor.com>

stale bot added the stale label Jul 10, 2022

stale bot closed this as completed Nov 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature Request] "convert --images" list only built images #8994

[Feature Request] "convert --images" list only built images #8994

abdennour commented Dec 4, 2021 •

edited

Loading

abdennour commented Dec 4, 2021

ndeloof commented Dec 4, 2021

abdennour commented Dec 4, 2021 •

edited

Loading

abdennour commented Dec 4, 2021 •

edited

Loading

abdennour commented Dec 6, 2021 •

edited

Loading

abdennour commented Dec 10, 2021

abdennour commented Dec 17, 2021

abdennour commented Dec 19, 2021

stale bot commented Jul 10, 2022

stale bot commented Nov 2, 2022

[Feature Request] "convert --images" list only built images #8994

[Feature Request] "convert --images" list only built images #8994

Comments

abdennour commented Dec 4, 2021 • edited Loading

abdennour commented Dec 4, 2021

ndeloof commented Dec 4, 2021

abdennour commented Dec 4, 2021 • edited Loading

abdennour commented Dec 4, 2021 • edited Loading

abdennour commented Dec 6, 2021 • edited Loading

abdennour commented Dec 10, 2021

abdennour commented Dec 17, 2021

abdennour commented Dec 19, 2021

stale bot commented Jul 10, 2022

stale bot commented Nov 2, 2022

abdennour commented Dec 4, 2021 •

edited

Loading

abdennour commented Dec 4, 2021 •

edited

Loading

abdennour commented Dec 4, 2021 •

edited

Loading

abdennour commented Dec 6, 2021 •

edited

Loading