Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup tips from output #10047

Merged
merged 1 commit into from
Dec 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions pkg/compose/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ func (s *composeService) Build(ctx context.Context, project *types.Project, opti

func (s *composeService) build(ctx context.Context, project *types.Project, options api.BuildOptions) error {
opts := map[string]build.Options{}
var imagesToBuild []string

args := flatten(options.Args.Resolve(envResolver(project.Environment)))

services, err := project.GetServices(options.Services...)
Expand All @@ -62,7 +60,6 @@ func (s *composeService) build(ctx context.Context, project *types.Project, opti
continue
}
imageName := api.GetImageNameOrDefault(service, project.Name)
imagesToBuild = append(imagesToBuild, imageName)
buildOptions, err := s.toBuildOptions(project, service, imageName, options.SSHs)
if err != nil {
return err
Expand Down Expand Up @@ -97,12 +94,6 @@ func (s *composeService) build(ctx context.Context, project *types.Project, opti
}

_, err = s.doBuild(ctx, project, opts, options.Progress)
if err == nil {
if len(imagesToBuild) > 0 && !options.Quiet {
utils.DisplayScanSuggestMsg()
}
}

return err
}

Expand Down Expand Up @@ -136,9 +127,6 @@ func (s *composeService) ensureImagesExists(ctx context.Context, project *types.
return err
}

if len(builtImages) > 0 {
utils.DisplayScanSuggestMsg()
}
for name, digest := range builtImages {
images[name] = digest
}
Expand Down
82 changes: 0 additions & 82 deletions pkg/e2e/scan_message_test.go

This file was deleted.

86 changes: 0 additions & 86 deletions pkg/utils/scan_suggest.go

This file was deleted.