resolve --env-file as absolute path #10074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
absolute_envfile
branch
from
af1369b
to
be89c86
Compare
Codecov ReportBase: 77.02% // Head: 77.02% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #10074 +/- ##
=======================================
Coverage 77.02% 77.02%
=======================================
Files 2 2
Lines 235 235
=======================================
Hits 181 181
Misses 48 48
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ndeloof
force-pushed
the
absolute_envfile
branch
from
be89c86
to
f508e11
Compare
ndeloof
requested review from
ulyssessouza,
milas,
nicksieger,
laurazard and
glours
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
absolute_envfile
branch
from
f508e11
to
b9dc36c
Compare
milas
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
converting
--env-filepath to an absolute path was only managed bytoProject. Moving logic to flag parsing enforce this always takes placeRelated issue
close #8930
(not mandatory) A picture of a cute animal, if possible in relation to what you did
