use compose service methods when exist instead of directly service.dockerCli #10175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckerCli Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Codecov ReportBase: 74.26% // Head: 73.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10175 +/- ##
==========================================
- Coverage 74.26% 73.89% -0.37%
==========================================
Files 2 2
Lines 272 272
==========================================
- Hits 202 201 -1
- Misses 59 60 +1
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ndeloof
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com
What I did
use internal functions of
composeServicestruct when exist instead of accessing via thecomposeService.dockerCliattributeRelated issue
see discussions in #10173
(not mandatory) A picture of a cute animal, if possible in relation to what you did
