Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix Goroutine leak in v2/command/formatter" #10197

Merged
merged 1 commit into from Jan 24, 2023
Merged

Revert "Fix Goroutine leak in v2/command/formatter" #10197

merged 1 commit into from Jan 24, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jan 24, 2023

Reverts #10192
this break compose up, as defer cleanInfiniteGoroutine() takes place immediately after init execution and prevent use of colors

@ndeloof ndeloof requested a review from glours January 24, 2023 09:47
glours
glours approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 5919fcb into v2 Jan 24, 2023
@ndeloof ndeloof deleted the revert-10192-10157-fix-goroutine-leak branch January 24, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ndeloof @glours