10157 fix goroutine leak v2 #10202
Merged
10157 fix goroutine leak v2 #10202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedGrati
force-pushed
the
10157-fix-goroutine-leak-v2
branch
from
b21c763
to
07aa1cf
Compare
laurazard
requested review from
a team,
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
ndeloof
requested changes
Jan 25, 2023
ndeloof
approved these changes
Jan 25, 2023
AhmedGrati
requested review from
ndeloof
and removed request for
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
Codecov ReportBase: 73.89% // Head: 73.89% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #10202 +/- ##
=======================================
Coverage 73.89% 73.89%
=======================================
Files 2 2
Lines 272 272
=======================================
Hits 201 201
Misses 60 60
Partials 11 11 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ndeloof
approved these changes
Jan 25, 2023
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
glours
force-pushed
the
10157-fix-goroutine-leak-v2
branch
from
d9d3bfc
to
e6ef041
Compare
laurazard
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed the goroutine leak, by removing the infinite goroutine that will send colors to the channel, and then refactored the
rainbowColor()function inside thecolors.go, to replace the logic of the infinite goroutine.Related issue
Fixes #10157.
Screenshots of testing
