exclude unstable labels from config hash #10275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
laurazard
approved these changes
Feb 13, 2023
Codecov ReportBase: 72.79% // Head: 72.79% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #10275 +/- ##
=======================================
Coverage 72.79% 72.79%
=======================================
Files 2 2
Lines 272 272
=======================================
Hits 198 198
Misses 62 62
Partials 12 12 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This is a fix for a different bug than the one reported in #9600 . That issue should be re-opened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
since 2.16.0 we introduced a
replacelabel to track relationship between new container and the one it replacesthis label is transient, and MUST not be considered for config hash computation
Related issue
close #9600
(not mandatory) A picture of a cute animal, if possible in relation to what you did