test: tweak pause test to try and prevent failures in Windows CI #10320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test keeps failing with a timeout in Windows. I don't actually think it should take that long to bring up an nginx container, so I'm guessing that there's something else going on that's causing trouble. Increase the verbosity when running Compose commands: I think this will generally make E2E test failures easier to diagnose by always logging the full command that's going to be run and also capturing stdout. Add a health check and use `--wait` when launching the fixture for the pause test. Combined with the verbosity increase, this should make it easier to understand what's going on here. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
laurazard
and removed request for
a team
glours
approved these changes
Mar 1, 2023
StefanScherer
approved these changes
Mar 1, 2023
ndeloof
approved these changes
Mar 1, 2023
| @@ -2,8 +2,16 @@ services: | |||
| a: | |||
| image: nginx:alpine | |||
| ports: [80] | |||
| healthcheck: | |||
| test: wget --spider -S -T1 http://localhost:80 | |||
There was a problem hiding this comment.
I didn't know about this --spider flag :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test keeps failing with a timeout in Windows. I don't actually think it should take that long to bring up an nginx container, so I'm guessing that there's something else going on that's causing trouble.
Increase the verbosity when running Compose commands: I think this will generally make E2E test failures easier to diagnose by always logging the full command that's going to be run and also capturing stdout.
Add a health check and use
--waitwhen launching the fixture for the pause test. Combined with the verbosity increase, this should make it easier to understand what's going on here.