Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use progress to show copy status #10387

Merged
merged 1 commit into from Mar 21, 2023
Merged

use progress to show copy status #10387

merged 1 commit into from Mar 21, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Mar 21, 2023

What I did
used progress to display cp status

docker compose cp foo test:/work
[+] Running 10/10
 ✔ truc-test-1 copy foo to truc-test-1:/work   Copied                                                                             0.1s 
 ✔ truc-test-5 copy foo to truc-test-5:/work   Copied                                                                             0.1s 
 ✔ truc-test-8 copy foo to truc-test-8:/work   Copied                                                                             0.1s 
 ✔ truc-test-2 copy foo to truc-test-2:/work   Copied                                                                             0.1s 
 ✔ truc-test-7 copy foo to truc-test-7:/work   Copied                                                                             0.1s 
 ✔ truc-test-3 copy foo to truc-test-3:/work   Copied                                                                             0.1s 
 ✔ truc-test-4 copy foo to truc-test-4:/work   Copied                                                                             0.1s 
 ✔ truc-test-6 copy foo to truc-test-6:/work   Copied                                                                             0.1s 
 ✔ truc-test-9 copy foo to truc-test-9:/work   Copied                                                                             0.1s 
 ✔ truc-test-10 copy foo to truc-test-10:/work Copied                                                                             0.1s 

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (03f0ed1) 53.41% compared to head (d1b491e) 53.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10387      +/-   ##
==========================================
+ Coverage   53.41%   53.45%   +0.04%     
==========================================
  Files         104      104              
  Lines        8942     8961      +19     
==========================================
+ Hits         4776     4790      +14     
- Misses       3646     3650       +4     
- Partials      520      521       +1     
Impacted Files Coverage Δ
pkg/compose/cp.go 60.60% <100.00%> (+3.53%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team March 21, 2023 08:38
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 9e19bc8 into docker:v2 Mar 21, 2023
24 checks passed
@ndeloof ndeloof deleted the cp_progress branch December 20, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants