watch involves up --build after change has been detected #10399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10399 +/- ##
==========================================
+ Coverage 60.09% 60.14% +0.04%
==========================================
Files 104 104
Lines 9012 9005 -7
==========================================
Hits 5416 5416
+ Misses 3030 3023 -7
Partials 566 566
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
removed explicit request to rebuild images, then invoke up. Replaced by configuring services watched to have pull_policy=build so that images will always been rebuild.
watchto rebuild image after changes has been detected is then strictly equivalent tocompose up --build SERVICERelated issue
As reported by @milas, after an initial rebuild,
watchwould runupbut not rebuild anymore(not mandatory) A picture of a cute animal, if possible in relation to what you did
