Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dry-run support to down command #10444

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

glours
Copy link
Contributor

@glours glours commented Apr 6, 2023

What I did
Add dry-run support for down command

> docker compose -f /Users/glours/sources/awesome-compose/nginx-golang-mysql/compose.yaml alpha dry-run -- down --rmi all --remove-orphans -v
[+] Running 10/0
 ✔ DRY-RUN MODE -  Container nginx-golang-mysql-proxy-1                 Removed                                                                                                                                                    0.0s 
 ✔ DRY-RUN MODE -  Container nginx-golang-mysql-proxy-run-a63195491410  Removed                                                                                                                                                    0.0s 
 ✔ DRY-RUN MODE -  Container nginx-golang-mysql-proxy-run-7c913f2c92a3  Removed                                                                                                                                                    0.0s 
 ✔ DRY-RUN MODE -  Container nginx-golang-mysql-backend-1               Removed                                                                                                                                                    0.0s 
 ✔ DRY-RUN MODE -  Container nginx-golang-mysql-db-1                    Removed                                                                                                                                                    0.0s 
 ✔ DRY-RUN MODE -  Volume nginx-golang-mysql_db-data                    Removed                                                                                                                                                    0.0s 
 ✔ DRY-RUN MODE -  Image mariadb:10-focal                               Removed                                                                                                                                                    0.0s 
 ✔ DRY-RUN MODE -  Image nginx-golang-mysql-backend:latest              Removed                                                                                                                                                    0.0s 
 ✔ DRY-RUN MODE -  Image nginx:latest                                   Removed                                                                                                                                                    0.0s 
 ✔ DRY-RUN MODE -  Network nginx-golang-mysql_default                   Removed                                                                                                                                                    0.0s

Related issue
https://docker.atlassian.net/browse/ENV-60

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@glours glours self-assigned this Apr 6, 2023
@glours glours requested review from a team, nicksieger, ndeloof, StefanScherer, ulyssessouza, milas and laurazard and removed request for a team April 6, 2023 13:25
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (eb933ad) 59.76% compared to head (7fb8785) 59.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10444   +/-   ##
=======================================
  Coverage   59.76%   59.76%           
=======================================
  Files         105      105           
  Lines        9074     9074           
=======================================
  Hits         5423     5423           
  Misses       3080     3080           
  Partials      571      571           
Impacted Files Coverage Δ
pkg/api/dryrunclient.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours merged commit a99acd9 into docker:v2 Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants