Remove redundant goroutine while removing containers #10449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TP-O
force-pushed
the
redundant-goroutine-while-removing-containers
branch
4 times, most recently
from
3070340
to
eb69929
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10449 +/- ##
==========================================
+ Coverage 59.81% 59.90% +0.08%
==========================================
Files 105 105
Lines 9074 9056 -18
==========================================
- Hits 5428 5425 -3
+ Misses 3076 3066 -10
+ Partials 570 565 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: TP-O <letranphong2k1@gmail.com>
TP-O
force-pushed
the
redundant-goroutine-while-removing-containers
branch
from
eb69929
to
d94ef4f
Compare
ndeloof
approved these changes
Apr 17, 2023
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
milas
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Method removeContainers creates a goroutine for each removed container. With that goroutine, it also creates one more goroutine to stop the container before removing it (can be completed without creating goroutine). I still remove the created redundant goroutine.
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did