Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/opencontainers/image-spec from 1.1.0-rc2.0.20221005185240-3a7f492d3f1b to 1.1.0-rc.3 #10518

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 2, 2023

Bumps github.com/opencontainers/image-spec from 1.1.0-rc2.0.20221005185240-3a7f492d3f1b to 1.1.0-rc.3.

Release notes

Sourced from github.com/opencontainers/image-spec's releases.

v1.1.0-rc.3

Vote passed [+6 -0]: https://groups.google.com/a/opencontainers.org/g/dev/c/ZUza21145X0

opencontainers/image-spec#1049

v1.1.0-rc3

Vote passed [+6 -0]: https://groups.google.com/a/opencontainers.org/g/dev/c/ZUza21145X0

opencontainers/image-spec#1049

Note: This is a duplicate of v1.1.0-rc.3 because of semver ordering (rc.3 < rc1 < rc2).

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/opencontainers/image-spec](https://github.com/opencontainers/image-spec) from 1.1.0-rc2.0.20221005185240-3a7f492d3f1b to 1.1.0-rc.3.
- [Release notes](https://github.com/opencontainers/image-spec/releases)
- [Changelog](https://github.com/opencontainers/image-spec/blob/main/RELEASES.md)
- [Commits](https://github.com/opencontainers/image-spec/commits/v1.1.0-rc3)

---
updated-dependencies:
- dependency-name: github.com/opencontainers/image-spec
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c136986) 19.55% compared to head (d54a95f) 19.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10518   +/-   ##
=======================================
  Coverage   19.55%   19.55%           
=======================================
  Files         104      104           
  Lines        9104     9104           
=======================================
  Hits         1780     1780           
  Misses       7137     7137           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glours glours enabled auto-merge May 2, 2023 10:05
@glours glours merged commit 74fc40d into v2 May 2, 2023
24 checks passed
@glours glours deleted the dependabot/go_modules/github.com/opencontainers/image-spec-1.1.0-rc.3 branch May 2, 2023 10:11
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is not compatible with BuildKit v0.11, so we can't use it; see moby/buildkit#3104

github.com/moby/buildkit v0.11.6
github.com/moby/buildkit v0.11.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rolling back buildkit and containerd releases

github.com/moby/term v0.0.0-20221205130635-1aeaba878587
github.com/morikuni/aec v1.0.0
github.com/opencontainers/go-digest v1.0.0
github.com/opencontainers/image-spec v1.1.0-rc2.0.20221005185240-3a7f492d3f1b
github.com/opencontainers/image-spec v1.1.0-rc.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use v1.1.0-rc3 instead; v1.1.0-rc.3 ranks lower than v1.1.0-rc2 according to SemVer (due to the missing dot); https://github.com/opencontainers/image-spec/releases/tag/v1.1.0-rc3

See moby/moby#45437

@thaJeztah
Copy link
Member

@glours we must revert this one (see my comments)

@glours
Copy link
Contributor

glours commented May 2, 2023

@thaJeztah done, see #10519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants