fix builkit progressui integration #10535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10535 +/- ##
==========================================
+ Coverage 59.77% 59.79% +0.01%
==========================================
Files 107 107
Lines 9291 9294 +3
==========================================
+ Hits 5554 5557 +3
+ Misses 3169 3168 -1
- Partials 568 569 +1
☔ View full report in Codecov by Sentry. |
ndeloof
force-pushed
the
build_fix
branch
3 times, most recently
from
90eaedd
to
8546b0a
Compare
milas
suggested changes
May 5, 2023
ndeloof
force-pushed
the
build_fix
branch
2 times, most recently
from
1f89aa1
to
c4d5892
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
share progressui for all images being built, isolate concurrent image builds using
buildx.WithPrefixthis is a simpler alternative to #10531, which we could include in a patch release
Related issue
fix #10528
(not mandatory) A picture of a cute animal, if possible in relation to what you did