Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix container being recreated while config has not changed #10540

Merged
merged 1 commit into from May 9, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented May 9, 2023

What I did
As we don't load project WithDiscardEnvFile the config hash includes env_file attribute. But when selecting service(s) to be ran, compose-go EnableService always applies the discard option (this could be considered a bug, but that's another discussion :P)

Related issue
fixes #10068

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06 ⚠️

Comparison is base (6ee0376) 59.79% compared to head (02293bb) 59.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10540      +/-   ##
==========================================
- Coverage   59.79%   59.73%   -0.06%     
==========================================
  Files         107      107              
  Lines        9294     9294              
==========================================
- Hits         5557     5552       -5     
- Misses       3168     3172       +4     
- Partials      569      570       +1     
Impacted Files Coverage Δ
cmd/compose/compose.go 73.98% <100.00%> (ø)
cmd/compose/run.go 68.47% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndeloof ndeloof requested a review from a team May 9, 2023 11:38
@milas milas merged commit 0c1a691 into docker:v2 May 9, 2023
23 of 24 checks passed
@ndeloof ndeloof deleted the fix_recreate branch May 10, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

container re-created when it shouldn't
3 participants