fix race condition when --parallel is used with a large number of dependent services #10544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
ndeloof
force-pushed
the
parallel_race
branch
3 times, most recently
from
e453368
to
ad25e52
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10544 +/- ##
==========================================
+ Coverage 59.81% 59.89% +0.08%
==========================================
Files 107 107
Lines 9294 9306 +12
==========================================
+ Hits 5559 5574 +15
+ Misses 3166 3165 -1
+ Partials 569 567 -2
☔ View full report in Codecov by Sentry. |
ndeloof
force-pushed
the
parallel_race
branch
5 times, most recently
from
e0b010a
to
c8cbcee
Compare
…ervices Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
dependency graph traversal has been implemented with recursive calls, this prevent the error group max concurrency to be used as a parallel limit: a Node visitor, once completed, won't leave the routine concurrent slot for another use.
This PR changes the approach by introducing a "controller" routine, responsible to trigger visit of the adjacent nodes. Visitor notify abut completion by aa channel, doing so the routine can complete. This require limit to be set to concurrency + 1 for the controller. Controller exits after all nodes have been visited.
Related issue
fixes #10532
(not mandatory) A picture of a cute animal, if possible in relation to what you did