Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce ability to write status messages on stdout #10549

Merged
merged 1 commit into from May 11, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented May 10, 2023

What I did
introduce stdinfo() as output stream to dump status messages about compose progress applying requested operation.
this defaults to POSIX stderr (to easily filter out container output on stdout) but can be switched by setting COMPOSE_STATUS_STDOUT=1

Related issue
closes #7346

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 55.88% and project coverage change: -0.07 ⚠️

Comparison is base (0c1a691) 59.81% compared to head (2da4c8a) 59.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10549      +/-   ##
==========================================
- Coverage   59.81%   59.75%   -0.07%     
==========================================
  Files         107      107              
  Lines        9294     9317      +23     
==========================================
+ Hits         5559     5567       +8     
- Misses       3166     3178      +12     
- Partials      569      572       +3     
Impacted Files Coverage Δ
pkg/compose/kill.go 56.09% <0.00%> (-1.41%) ⬇️
pkg/compose/push.go 0.00% <0.00%> (ø)
pkg/compose/watch.go 24.25% <20.00%> (-0.86%) ⬇️
pkg/compose/compose.go 65.43% <40.00%> (-1.68%) ⬇️
pkg/compose/pause.go 43.47% <50.00%> (ø)
pkg/compose/build.go 76.63% <100.00%> (ø)
pkg/compose/cp.go 60.60% <100.00%> (ø)
pkg/compose/create.go 61.41% <100.00%> (ø)
pkg/compose/down.go 69.12% <100.00%> (ø)
pkg/compose/pull.go 76.72% <100.00%> (ø)
... and 5 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🥳 I'm super happy to finally be able to configure this :)

@milas milas merged commit a14abb9 into docker:v2 May 11, 2023
22 of 24 checks passed
@ndeloof ndeloof deleted the compose_status_stdout branch December 20, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why does docker-compose log to STDERR for Building .... instead of STDOUT when executing docker-compose build
3 participants