fix local image removal when compose down is ran with --project-name
#10558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10558 +/- ##
==========================================
- Coverage 59.66% 59.63% -0.03%
==========================================
Files 107 107
Lines 9324 9318 -6
==========================================
- Hits 5563 5557 -6
Misses 3190 3190
Partials 571 571
☔ View full report in Codecov by Sentry. |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
milas
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
As previously noted in comment, with built image being tagged to make listing more deterministic, we don't need anymore to check service.image being set. Running with
--project-namethis attribute is always set, whenever it might not have been in the initial compose.yaml file.Related issue
closes #9914
(not mandatory) A picture of a cute animal, if possible in relation to what you did