Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] --parallel has precedence over COMPOSE_PARALLEL_LIMIT #10566

Merged
merged 1 commit into from May 15, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented May 14, 2023

What I did
As we check --parallel flag has been set, we have to check the "compose" top-level command, not the current one. Surprisingly, cobra ignores request to check a changed flag for undefined flag, otherwise we would have detected this earlier

also groups COMPOSE_* definition as constants as boy scout "clean code" principle

Related issue
fixes #10547

(not mandatory) A picture of a cute animal, if possible in relation to what you did

…current one

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Patch coverage: 61.11% and no project coverage change.

Comparison is base (77dc9b5) 59.59% compared to head (3340f7f) 59.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10566   +/-   ##
=======================================
  Coverage   59.59%   59.59%           
=======================================
  Files         107      107           
  Lines        9341     9349    +8     
=======================================
+ Hits         5567     5572    +5     
- Misses       3199     3201    +2     
- Partials      575      576    +1     
Impacted Files Coverage Δ
cmd/compose/up.go 70.00% <50.00%> (ø)
cmd/compose/compose.go 73.77% <53.84%> (-0.31%) ⬇️
cmd/compose/down.go 78.72% <100.00%> (ø)
cmd/compose/kill.go 48.14% <100.00%> (ø)
cmd/compose/run.go 68.47% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit fd7847f into docker:v2 May 15, 2023
24 checks passed
@ndeloof ndeloof deleted the parallel_PARALLEL branch May 15, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] environment variable COMPOSE_PARALLEL_LIMIT has precedence over --parallel commandline parameter
2 participants