only set CopyUIDGID when secret is requested to set gid/uid #10598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10598 +/- ##
==========================================
- Coverage 59.56% 59.54% -0.03%
==========================================
Files 107 107
Lines 9359 9359
==========================================
- Hits 5575 5573 -2
- Misses 3210 3212 +2
Partials 574 574
☔ View full report in Codecov by Sentry. |
milas
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
only set CopyUIDGID when secret configuration explicitly requires to set uid/gid, otherwise we get hurt by moby/moby#34142
Related issue
(partially) fixes #10595
(not mandatory) A picture of a cute animal, if possible in relation to what you did