Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only watch configured paths #10599

Merged
merged 1 commit into from May 23, 2023
Merged

only watch configured paths #10599

merged 1 commit into from May 23, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented May 23, 2023

What I did
x-develop has got a bit of a wandering eye - It watches the whole build context instead of just the watch paths

Related issue
(https://docker.atlassian.net/browse/ENV-192)

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team May 23, 2023 08:20
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (544b579) 59.48% compared to head (df18a15) 59.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10599      +/-   ##
==========================================
- Coverage   59.48%   59.41%   -0.07%     
==========================================
  Files         107      107              
  Lines        9359     9361       +2     
==========================================
- Hits         5567     5562       -5     
- Misses       3216     3222       +6     
- Partials      576      577       +1     
Impacted Files Coverage Δ
pkg/compose/watch.go 24.05% <0.00%> (-0.21%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@milas milas merged commit 916aac6 into docker:v2 May 23, 2023
22 of 24 checks passed
@ndeloof ndeloof deleted the watch_paths branch December 20, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants