Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump golangci-lint to v1.53.x #10659

Merged
merged 1 commit into from Jun 6, 2023
Merged

Conversation

milas
Copy link
Member

@milas milas commented Jun 6, 2023

What I did
Upgrade golangci-lint to v1.53.2. (Mostly because I occasionally run my local install from Homebrew and it was annoying me that it was giving false positives due to config file format changes.)

Related issue
n/a

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

Requires some changes for depguard config

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas milas requested a review from a team June 6, 2023 13:54
@milas milas self-assigned this Jun 6, 2023
@milas milas requested review from nicksieger, ndeloof, StefanScherer, ulyssessouza, glours and laurazard and removed request for a team June 6, 2023 13:54
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -40.34 ⚠️

Comparison is base (7c3fe35) 59.71% compared to head (6499353) 19.38%.

Additional details and impacted files
@@             Coverage Diff             @@
##               v2   #10659       +/-   ##
===========================================
- Coverage   59.71%   19.38%   -40.34%     
===========================================
  Files         107      104        -3     
  Lines        9481     9388       -93     
===========================================
- Hits         5662     1820     -3842     
- Misses       3236     7372     +4136     
+ Partials      583      196      -387     

see 81 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@milas milas merged commit be6c956 into docker:v2 Jun 6, 2023
23 of 24 checks passed
@milas milas deleted the golangci-lint-1.53 branch June 6, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants