support attach
#10700
Merged
support attach
#10700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10700 +/- ##
==========================================
+ Coverage 59.15% 59.17% +0.01%
==========================================
Files 115 115
Lines 9853 9869 +16
==========================================
+ Hits 5829 5840 +11
- Misses 3434 3437 +3
- Partials 590 592 +2
☔ View full report in Codecov by Sentry. |
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
milas
reviewed
Jun 27, 2023
cmd/compose/up.go
Outdated
Comment on lines
171
to
174
| if err := project.WithServices(attachTo, func(s types.ServiceConfig) error { | ||
| if s.Attach == nil || *s.Attach { | ||
| attachTo = append(attachTo, s.Name) | ||
| } |
There was a problem hiding this comment.
If upOptions.attach is not empty, won't this add duplicates?
ndeloof
force-pushed
the
attach
branch
4 times, most recently
from
62100a9
to
53f2f00
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
glours
approved these changes
Jul 10, 2023
milas
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add support for
attachin service config, which can be overridden by command line--attach --no-attachRelated issue
closes #10695
(not mandatory) A picture of a cute animal, if possible in relation to what you did