Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos #10740

Merged
merged 1 commit into from Jun 27, 2023
Merged

fix typos #10740

merged 1 commit into from Jun 27, 2023

Conversation

callthingsoff
Copy link
Contributor

What I did

fix typos

laurazard
laurazard approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@laurazard
Copy link
Member

laurazard commented Jun 25, 2023 •
edited

Ah it looks like your commit message is missing a DCO sign-off still, causing the DCO check to fail.

We require all commit messages to have a Signed-off-by line with your name and e-mail, which looks something like:

Signed-off-by: YourFirsName YourLastName <yourname@example.org>

You can find some instructions on how to amend your commits to include the sign-off line in the output of the DCO check.

Sorry for the hassle, and thanks again for the contribution :)

@callthingsoff
Copy link
Contributor Author

Ah it looks like your commit message is missing a DCO sign-off still, causing the DCO check to fail.

We require all commit messages to have a Signed-off-by line with your name and e-mail, which looks something like:

Signed-off-by: YourFirsName YourLastName <yourname@example.org>

You can find some instructions on how to amend your commits to include the sign-off line in the output of the DCO check.

Sorry for the hassle, and thanks again for the contribution :)

Thanks, done.

@callthingsoff
Copy link
Contributor Author

Friendly ping, it seems that these checks will take a long time.

@ndeloof ndeloof enabled auto-merge (rebase) June 27, 2023 13:59
@callthingsoff @ndeloof
fix typos
4c85ca1 
Signed-off-by: Jes Cok <xigua67damn@gmail.com>
@ndeloof ndeloof merged commit 1a41678 into docker:v2 Jun 27, 2023
23 checks passed
@callthingsoff callthingsoff deleted the v2_typos branch June 27, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndeloof ndeloof ndeloof approved these changes

@laurazard laurazard laurazard approved these changes

@glours glours Awaiting requested review from glours

@milas milas Awaiting requested review from milas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@callthingsoff @laurazard @ndeloof