Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include image name in error message #11006

Merged
merged 1 commit into from Sep 29, 2023

Conversation

mattwalo32
Copy link
Contributor

What I did
Added a more descriptive error message for images with invalid reference formats

Related issue
Fixes #10795

(not mandatory) A picture of a cute animal, if possible in relation to what you did
Tortoise

Signed-off-by: Matthew Walowski <mattwalowski@gmail.com>
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07% 🎉

Comparison is base (8af49ff) 57.92% compared to head (b3622ad) 57.99%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11006      +/-   ##
==========================================
+ Coverage   57.92%   57.99%   +0.07%     
==========================================
  Files         129      129              
  Lines       11108    11108              
==========================================
+ Hits         6434     6442       +8     
+ Misses       4042     4035       -7     
+ Partials      632      631       -1     
Files Changed Coverage Δ
pkg/compose/images.go 72.60% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndeloof ndeloof merged commit 6ecab95 into docker:main Sep 29, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: print the name of invalid image references
2 participants