[DNM] Run tests against the c8d image store #11046
Draft
+46
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11046 +/- ##
==========================================
+ Coverage 56.20% 56.29% +0.09%
==========================================
Files 134 134
Lines 11564 11564
==========================================
+ Hits 6499 6510 +11
+ Misses 4421 4413 -8
+ Partials 644 641 -3 ☔ View full report in Codecov by Sentry. |
rumpl
changed the title
crazy-max
reviewed
Sep 28, 2023
.github/workflows/ci.yml
Outdated
Comment on lines
223
to
235
| - | ||
| name: Setup docker CLI | ||
| run: | | ||
| curl https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKER_CLI_VERSION}.tgz | tar xz | ||
| sudo cp ./docker/docker /usr/bin/ && rm -rf docker && docker version |
There was a problem hiding this comment.
This will be overridden by crazy-max/ghaction-setup-docker (24.0.6). See https://github.com/docker/compose/actions/runs/6338599258/job/17216038445?pr=11046#step:7:261
There was a problem hiding this comment.
Thanks for the info, that's fine
Added a job that will run e2e tests against a docker daemon that has the containerd-integration feature enabled. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added a job that will run e2e tests against a docker daemon that has the containerd-integration feature enabled.
Note: Adding this as a draft PR, I don't necessarily expect you to merge this one but I want to see what (if anything) fails with the containerd integration
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did