Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cucumber tests as we haven't added new ones for a while #11076

Merged
merged 1 commit into from Oct 10, 2023

Conversation

glours
Copy link
Contributor

@glours glours commented Oct 10, 2023

What I did
Remove cucumber tests as we only added 2 new ones since we introduced them, it costs us CI time and we should give a huge engineering effort to provide a good coverage using them

Related issue
N/A

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9dd081b) 0.00% compared to head (14b43c1) 57.48%.

Additional details and impacted files
@@            Coverage Diff            @@
##           main   #11076       +/-   ##
=========================================
+ Coverage      0   57.48%   +57.48%     
=========================================
  Files         0      129      +129     
  Lines         0    11243    +11243     
=========================================
+ Hits          0     6463     +6463     
- Misses        0     4148     +4148     
- Partials      0      632      +632     

see 129 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glours glours marked this pull request as ready for review October 10, 2023 08:53
@glours glours self-assigned this Oct 10, 2023
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 👋

@glours glours merged commit b30978f into docker:main Oct 10, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants